[vpnc-devel] Asking for patch merge

[Davide Pucci]

Hi all.
I'm Davide Pucci, systems engineer and developer at I-Node S.r.l..
I got in contact with VPNC source code as I needed to make it read and load connection credentials via command line, obfuscating them in ps - or similar - process view.
So, I wrote a patch that:


1. firstly allow the group secret and the user password to be passed in command line in argv
2. secondly, included a new field in config_name_s struct to include an integer needsEncryption field, passed in config_names array, to trigger eventual obfuscation of field in process argv
3. finally, in argument parsing phase, if a field asks for encryption (obfuscation) via needsEncryption field, I populate the config value pointer with a new one, referencing a new memory location containing the original argv[i] pointing value, and replace argv[i] pointing value with a random string.

The full patch is sent as attachment.
I'm writing this just to know if there's a way to officially ask for this to be included in mainstream branch.
Waiting for any feedback.

Regards,
Davide Pucci.

**********

Davide Pucci
Systems and Software Engineer
Mob: [phone]
Tel: [phone]
Fax: [phone]
Email: ***@i-node.it

I-node s.r.l.
We build you® .biz
Via Laurentina, 86 - 00142 Roma (RM)
Twitter: http://www.twitter.com/i_node
Sito Web: http://www.i-node.it

[David Woodhouse]

Post by Davide Pucci
I'm writing this just to know if there's a way to officially ask for
this to be included in mainstream branch.

Even security fixes aren't being merged; vpnc development seems to be
dead. Someone could fork it and put up a new git tree elsewhere,
perhaps?

I actually suspect it might be a good idea just to add the missing
support to OpenConnect as as new protocol there. 

[Davide Pucci]

Right. It really needs to be someone who is willing to take on the long-term maintenance.

Repository created. Feel free now to fire your pull requests, I will read and accept them. :)

Regards,
Davide Pucci.

**********

Davide Pucci
Systems and Software Engineer
Mob: [phone]
Tel: [phone]
Fax: [phone]
Email: ***@i-node.it

I-node s.r.l.
We build you® .biz
Via Laurentina, 86 - 00142 Roma (RM)
Twitter: http://www.twitter.com/i_node
Sito Web: http://www.i-node.it


Da: "David Woodhouse" <***@infradead.org>
A: "d pucci" <***@i-node.it>
Cc: "vpnc-devel" <vpnc-***@unix-ag.uni-kl.de>
Inviato: Venerdì, 17 novembre 2017 11:53:15
Oggetto: Re: [vpnc-devel] Asking for patch merge

On Fri, 2017-11-17 at 11:41 +0100, Davide Pucci wrote:



Hi, David. Thank you for the feedback.

Someone could fork it and put up a new git tree elsewhere,
perhaps?

I could do it, but I would stop my contributions with my patch, and then actively merging eventual merge requests.



Right. It really needs to be someone who is willing to take on the long-term maintenance.

[David Woodhouse]

Post by Davide Pucci
Repository created. Feel free now to fire your pull requests, I will
read and accept them. :)

This wants fixing: https://lists.gt.net/vpnc/devel/4120

There have been subsequent updates to my version of the code since
then:
http://git.infradead.org/users/dwmw2/openconnect.git/history/HEAD:/esp-seqno.c

You can largely just lift that copy of esp-seqno.c and use it.

[Davide Pucci]

Good morning, David.
Sorry for the delay, your patch has been merged: https://github.com/streambinder/vpnc/commit/9cb925c670f170025a32128ad4aa09ece2b59d93

Regards,
Davide Pucci.

**********

Davide Pucci
Systems and Software Engineer
Mob: [phone]
Tel: [phone]
Fax: [phone]
Email: ***@i-node.it

I-node s.r.l.
We build you® .biz
Via di San Giovanni in Laterano, 84 - 00184 Roma (RM)
Twitter: http://www.twitter.com/i_node
Sito Web: http://www.i-node.it


Da: "David Woodhouse" <***@infradead.org>
A: "Davide Pucci" <***@i-node.it>
Cc: "vpnc-devel" <vpnc-***@unix-ag.uni-kl.de>
Inviato: Venerdì, 17 novembre 2017 12:45:10
Oggetto: Re: [vpnc-devel] Asking for patch merge

Post by Davide Pucci
Repository created. Feel free now to fire your pull requests, I will
read and accept them. :)

This wants fixing: https://lists.gt.net/vpnc/devel/4120

There have been subsequent updates to my version of the code since
then:
http://git.infradead.org/users/dwmw2/openconnect.git/history/HEAD:/esp-seqno.c

You can largely just lift that copy of esp-seqno.c and use it.